r907: weapons should pick up brands from rings

What if both rings have brands? I seem to remember Un only takes the right one into account, ever.

I've checked. In Un it's:

/* Handle normal weapon/gauntlets/boots */ if (o_ptr->k_idx) { k = damroll(o_ptr->dd, o_ptr->ds) ; /* Hack -- get brands/slays from artifact/ego item/magic item type */

if ((o_ptr->name1) (o_ptr->name2) (o_ptr->xtra1) (o_ptr->ident & (IDENT_FORGED))) { k = tot_dam_aux(o_ptr, k, m_ptr, FALSE) ; } /* Hack -- use gauntlet brand if wielding a normal weapon */ else if (inventory[INVEN_HANDS].k_idx) { k = tot_dam_aux(&inventory[INVEN_HANDS], k, m_ptr, FALSE) ; } /* Hack -- use ring brands if not wielding gloves */ else if ((inventory[INVEN_RIGHT].k_idx) && (slot == INVEN_WIELD)) { k = tot_dam_aux(&inventory[INVEN_RIGHT], k, m_ptr, FALSE) ; } /* Hack -- use ring brands if not wielding gloves */ else if ((inventory[INVEN_LEFT].k_idx) && (slot == INVEN_ARM)) { k = tot_dam_aux(&inventory[INVEN_LEFT], k, m_ptr, FALSE) ; }

but perhaps it would be better to sum left and right ring slays? Also, perhaps add slays even to egos and artifacts, not only to average weapons? I'm not sure about the second one, because the feature was meant to improve average weapons, mainly. Hmmm.

Anyway, after it's decided, I think I'd change things for Un, to stay close to V...

Maybe work around that by having the brands act like weapons with multiple slays, ie. have only the strongest brand that affects the attack add damage.