Ticket #56 (closed task: fixed)

Opened 1 year ago

Last modified 1 year ago

Make squelch simpler and cleaner

Reported by: takkaria Assigned to: takkaria
Milestone: 3.0.8 Version:
Keywords: ui Cc:

Description (Last modified by takkaria)

Basically, simplify a lot so it's no longer confusing, and make it work for mouse users. See comments for more details.

Attachments

Change History

03/29/07 20:22:53 changed by takkaria

  • status changed from new to assigned.

I think I'm going to significantly alter the patch after playtesting. It's too complex, and the UI is horrible.

  • add an option "autopickup things that match inventory"
  • add the ability to mark any given object as "destroy on sight"/"always pickup" (=k, =g autoinscriptions, probably)
  • remove the current interface for individual items, use the knowledge one instead
  • quality-based "destroy weapons/missiles/armour" on pseudo-id (works in pack, as current implementation, almost)

04/05/07 11:50:54 changed by pmac

I made a first hack at the Quality Squelch menu using the new menu API. It is infinitely simpler code; I don't know if the interface is better, although it is now usable with just a mouse.

04/09/07 19:03:37 changed by takkaria

Quote:

Since quality squelch doesn't get saved between characters anyway, I'm going to make things easier by removing the attempt to work for both weak- and strong- pseudo-id characters, and just have it use whichever one the current character has.

(follow-up: ↓ 6 ) 04/22/07 18:17:39 changed by takkaria

  • priority changed from normal to blocker.

04/22/07 18:17:49 changed by takkaria

  • type changed from feature to task.

(in reply to: ↑ 4 ) 04/22/07 22:23:43 changed by pmac

Replying to takkaria: Disagree. Strong-pseudo has real meaning for weak-pseudo characters. Better to just get rid of weak pseudo of "good" items, which is basically the same as squelch-all-but-artifacts. More useful is squelch cursed-but-not-worthless, which allows you to keep Bows of the Nazgul (for SI) but squelches all ordinary cursed bows.

04/22/07 22:26:42 changed by pmac

  • component changed from Maintenance to UI.

06/02/07 08:52:25 changed by takkaria

  • description changed.
  • summary changed from Clean up the squelch patch to Make squelch simpler and cleaner.

06/02/07 09:04:41 changed by takkaria

  • description changed.

06/02/07 09:11:45 changed by takkaria

  • description changed.

06/03/07 11:53:45 changed by takkaria

  • keywords set to ui.
  • component changed from Interface to Main game.

06/05/07 19:30:33 changed by takkaria

  • description changed.

Done today (will upload patch tomorrow):

Stop squelching items in the pack without choice. Mark items as {squelch} instead of actually being squelched, Ey-style. Auto-mark items as squelch when we find out they're bad (e.g. potions). 'k!' should bring up a menu of just the items to be squelched, to confirm, before hitting "y". Inscribing an item "!k" will rescue it from being squelched.

"Merge inscriptions" option should be always-on. "Verify destruction" option should be always-on.

Remove chest squelching. Remove ego-item squelching. Remove individual item squelch groups for pseudo-id-able items. They are handled using the quality squelch.

Remove item-based autopickup/neverpickup options, instead add:

Always pickup items matching those in inventory : on (pickup_inven)

06/06/07 08:25:30 changed by takkaria

  • description changed.

Done today (quality squelch screen not quite working fully yet, though):

Move all menus across to the new menu API -- possibly adding "multicolumn" menu display.

Simplify the quality squelch screen to give fewer options. A simple choice of weapons/missiles/armour/lights/etc rather than the massive number of subchoices will still be fine. Remove the crazy "all items" and "just this item" code, make the changes work on a per-group basis.

06/06/07 09:16:14 changed by takkaria

  • status changed from assigned to closed.
  • resolution set to fixed.
  • description changed.

in [156]. +667 lines, -1379 lines, -712 net.


Add/Change #56 (Make squelch simpler and cleaner)




Action