Ticket #429 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

Unused flags in defines.h

Reported by: Kenneth 'Bessarion' Boyd <zaimoni@zaimoni.com> Assigned to:
Milestone: 3.1.0 Keywords:
Cc:

Description

1) the MDESC_ family of flags is completely unused in the *.c files; looks like they should be used (bitvector style) to obviate non-zero magic constants for monster_desc.

2) MON_SUMMON_ADJ isn't used either. While it is the correct denominator for the summoned monster level calculation, I don't see how any clarity is to be gained from it (denominator is standard for arithmetic mean). I have eliminated this for Zaiband.

Attachments

Change History

01/29/08 04:46:11 changed by takkaria

second part fixed in [655].

01/29/08 04:59:47 changed by takkaria

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from 3.2.0 to 3.1.0.

See [656] for the first part; some of those flags are still unused, though. monster_desc() is still a very unclear function, though.

Add/Change #429 (Unused flags in defines.h)




Action