Ticket #344 (closed bug: fixed)

Opened 1 year ago

Last modified 7 months ago

p_ptr->command_wrk not reset in get_item()

Reported by: Big Al Assigned to:
Milestone: 3.1.0 Version:
Keywords: waiting ui Cc:

Description

If you do an action that requires the selection of an item, and the inventory list pops up by default, then you get odd behavior occasionally regarding browsing inventory vs. equipment.

Eg, in a shop:

  • Press 'd' to sell an item; it (normally) shows you a list of your inventory that you can sell.
  • Then, you can press '/' to view your equipment that you can sell.
  • Sell an item (or just cancel the prompt).
  • Press 'd' again to sell another item; it now shows the list of equipment that you can sell, not the inventory as expected.

I think adding p_ptr->command_wrk = FALSE; to somewhere near the end of get_item() should fix it.

Attachments

Change History

08/12/07 12:19:35 changed by takkaria

This is the way it works everywhere -- try it with the 'I' command outside the store. I think this is an intentional feature.

08/12/07 12:23:03 changed by takkaria

  • keywords changed from ui to waiting ui.

08/13/07 00:32:28 changed by Big Al

If it's designed to be like that, then I guess that's ok, but I generally like things consistent. If I want to drop object 'e' in the inventory, I feel as though I should be able to press 'de' to drop it, rather than press 'd', check if I'm on the inv or equip screen (that I may or may not have changed five minutes ago), press '/' if necessary, then press 'e'. Seems more complex this way.

08/25/07 07:55:05 changed by takkaria

  • milestone changed from 3.2.0 to 3.1.0.

09/28/07 12:22:24 changed by takkaria

  • status changed from new to closed.
  • resolution set to wontfix.

The feature is actually useful when e.g. examining objects in your equipment, and seeing as I haven't changed this, I'm wontfixing this bug.

02/26/08 04:18:46 changed by takkaria

  • status changed from closed to reopened.
  • resolution deleted.

My bad. I initially thought this was a good thing, turns out it's not. Fix in the pipeline.

02/26/08 04:21:36 changed by takkaria

  • status changed from reopened to closed.
  • resolution set to fixed.

Fix in r715. If you have any further problems, please file a new bug. Thanks!

Add/Change #344 (p_ptr->command_wrk not reset in get_item())




Action