Ticket #159 (closed task: fixed)

Opened 1 year ago

Last modified 1 year ago

Trimming down the number of compile-time options

Reported by: CJNyfalt Assigned to:
Milestone: 3.0.8 Version:
Keywords: cleanup Cc:

Description (Last modified by takkaria)

Compile-time options (defines) are more annoying than in-game options because they are hard to debug, and should be kept to a minimum.

I suggest removal of the following (from config.h and other files):

  • SAFE_SETUID & SAFE_SETUID_POSIX (on): See my post on the forum some days ago.
  • ALLOW_AUTOROLLER (on): There are variants where the game won't even compile if this one is turned off.
  • ALLOW_REPEAT (on): This is an important part of the UI, and there should be no reason to turn it off.
  • CAPITALIZE_USER_NAME (on): No reason at all to have this as an option.

Other issues in config.h:

  • GJW_RANDART is still present in the ANGBAND_LITE block even if it has been removed.
  • MONSTER_FLOW_DEPTH doesn't belong in this file.
  • A comment on why Macs and Windows machines doesn't handle signals would also be welcome.

Attachments

Change History

06/20/07 09:20:26 changed by takkaria

  • description changed.

06/20/07 09:30:31 changed by takkaria

  • keywords changed from config.h options cleanup to cleanup.

(in reply to: ↑ description ; follow-up: ↓ 4 ) 06/20/07 09:56:37 changed by takkaria

Replying to CJNyfalt:

- SAFE_SETUID & SAFE_SETUID_POSIX (on): See my post on the forum some days ago.

See that forum thread for more info on this.

- ALLOW_AUTOROLLER (on): There are variants where the game won't even compile if this one is turned off.

The autoroller's going anyway, next version, so I don't see any harm with it being there either way.

- ALLOW_REPEAT (on): This is an important part of the UI, and there should be no reason to turn it off. - CAPITALIZE_USER_NAME (on): No reason at all to have this as an option.

Agreed.

Other issues in config.h: - GJW_RANDART is still present in the ANGBAND_LITE block even if it has been removed. - MONSTER_FLOW_DEPTH doesn't belong in this file. - A comment on why Macs and Windows machines doesn't handle signals would also be welcome.

I have no idea why they don't, actually, since I think they probably should...

(in reply to: ↑ 3 ) 06/20/07 14:07:29 changed by CJNyfalt

Replying to takkaria:

Replying to CJNyfalt:

- SAFE_SETUID & SAFE_SETUID_POSIX (on): See my post on the forum some days ago.

See that forum thread for more info on this.

Just a note that I took a look and added something you missed to the thread.

06/21/07 19:58:49 changed by takkaria

  • status changed from new to closed.
  • resolution set to fixed.

see [199] and [200].

Add/Change #159 (Trimming down the number of compile-time options)




Action